Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement lstsq #22953

Closed
wants to merge 6 commits into from
Closed

feat: implement lstsq #22953

wants to merge 6 commits into from

Conversation

HadeerArafa
Copy link

Close #22952

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2023

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on main, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@ivy-leaves ivy-leaves added the TensorFlow Frontend Developing the TensorFlow Frontend, checklist triggered by commenting add_frontend_checklist label Sep 2, 2023
@ivy-seed ivy-seed assigned illia-bab and D0m-inic and unassigned illia-bab Sep 2, 2023
@ivy-seed ivy-seed assigned paulaehab and unassigned D0m-inic Sep 18, 2023
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

@HadeerArafa HadeerArafa changed the title implement lstsq feat: implement lstsq Sep 19, 2023
@HadeerArafa
Copy link
Author

@paulaehab it's been 2 weeks can you review my code please, thanks for your time

@paulaehab
Copy link
Contributor

Hello @HadeerArafa sorry for late review, Nice work every thing look great for me 😄 there are error in the tests for Numpy backend could you have a look at it ?

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

Thank you for this PR, here is the CI results:


Failed tests:

This PR introduces the following new failing tests:
ivy_tests/test_ivy/test_frontends/test_torch/test_tensor.py::test_torch_tensor_neg,torch
ivy_tests/test_ivy/test_frontends/test_torch/test_tensor.py::test_torch_tensor_neg,paddle
ivy_tests/test_ivy/test_frontends/test_paddle/test_math.py::test_paddle_kron,torch
ivy_tests/test_ivy/test_frontends/test_torch/test_indexing_slicing_joining_mutating_ops.py::test_torch_stack,torch

@NripeshN NripeshN closed this Dec 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TensorFlow Frontend Developing the TensorFlow Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lstsq
6 participants